test(rds): wait for db instance available before chaining ops#821
Closed
vieiralucas wants to merge 1 commit intomainfrom
Closed
test(rds): wait for db instance available before chaining ops#821vieiralucas wants to merge 1 commit intomainfrom
vieiralucas wants to merge 1 commit intomainfrom
Conversation
CreateDBInstance is async (returns immediately with status="creating" and the postgres container starts in a background task). Conformance tests that chain operations on the new instance — CreateDBSnapshot, RebootDBInstance, ModifyDBInstance with apply_immediately, read replica creation, restore from snapshot, delete with final snapshot — were running against a "creating" instance and either erroring or observing intermediate state. 10 RDS tests have been failing on main since the async work landed. Adds wait_for_db_instance_available helper that polls DescribeDBInstances every 250ms (60s timeout) until status is "available". Wires it into the create_instance helper so every test that uses it gets a ready instance, and adds inline waits in the three tests that build the instance manually instead of going through the helper. Tests covered: rds_describe_db_instances, rds_create_db_snapshot, rds_describe_db_snapshots, rds_delete_db_snapshot, rds_describe_db_snapshots_pagination, rds_reboot_db_instance, rds_modify_db_instance_with_apply_immediately_false, rds_create_db_instance_read_replica, rds_restore_db_instance_from_db_snapshot, rds_delete_db_instance_with_final_snapshot.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vieiralucas
force-pushed
the
worktree-fix-rds-conformance-async-create
branch
from
f6707e1 to
5f7c3eb
Compare
Member
Author
|
Closing as duplicate. The RDS conformance regression from async CreateDBInstance was independently fixed and shipped via 738abf5 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conformance has been failing on main since the async CreateDBInstance work landed (`v0.13.1 deferred RDS shipped`, 2026-04-28). `CreateDBInstance` returns immediately with `status="creating"` and the real postgres container starts in a background task, but 10 RDS conformance tests were running follow-up ops (snapshot, reboot, modify, replica, restore, delete-with-final-snapshot) against a still-`creating` instance and either erroring or observing intermediate state.
Adds `wait_for_db_instance_available` polling helper and wires it into the `create_instance` test helper plus the three inline-create tests so all chained ops see an `available` instance.
Test plan
Summary by cubic
Fixes RDS conformance failures by waiting for a DB instance to be "available" before chaining follow-up operations in tests.
wait_for_db_instance_availablehelper (polls every 250ms, 60s timeout viaDescribeDBInstances).Written for commit 5f7c3eb. Summary will update on new commits. Review in cubic